Feature: Prevent discontinuities in timeseries #559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdubrock
approved these changes
Nov 3, 2023
If a check is configured with an interval longer than 5 minutes, the generated time series will have discontinuities in them. This PR adds logic to prevent those by repeating the last value of a series at the required interval to prevent discontinuities. This only affects metrics that are present between two consecutive executions of a check. Signed-off-by: Adrian Serrano <[email protected]>
mem
force-pushed
the
prevent_metric_gaps
branch
from
b633ecc
to
a58c704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a check is configured with an interval longer than 5 minutes, the generated time series will have discontinuities in them.
This PR adds logic to prevent those by repeating the last value of a series at the required interval to prevent discontinuities.
This only affects metrics that are present between two consecutive executions of a check.