manifestutils: configure CA and ServicePKI by name (#1039)

Signed-off-by: Benedikt Bongartz <[email protected]>
grafana · Sep 27, 2024 · f4cb97c · f4cb97c
1 parent fce6a2a
commit f4cb97c
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 12 deletions.
diff --git a/internal/manifests/manifestutils/service.go b/internal/manifests/manifestutils/service.go
@@ -8,6 +8,21 @@ import (
 	"github.com/grafana/tempo-operator/internal/manifests/naming"
 )
 
+// ConfigureServiceCAByContainerName modify the PodSpec adding the volumes and volumeMounts to the specified containers.
+func ConfigureServiceCAByContainerName(podSpec *corev1.PodSpec, caBundleName string, containers ...string) error {
+	targetContainers := map[string]struct{}{}
+	for _, name := range containers {
+		targetContainers[name] = struct{}{}
+	}
+	ids := []int{}
+	for id, c := range podSpec.Containers {
+		if _, exists := targetContainers[c.Name]; exists {
+			ids = append(ids, id)
+		}
+	}
+	return ConfigureServiceCA(podSpec, caBundleName, ids...)
+}
+
 // ConfigureServiceCA modify the PodSpec adding the volumes and volumeMounts to the specified containers.
 func ConfigureServiceCA(podSpec *corev1.PodSpec, caBundleName string, containers ...int) error {
 	secretVolumeSpec := corev1.PodSpec{
@@ -58,6 +73,21 @@ func ConfigureServiceCA(podSpec *corev1.PodSpec, caBundleName string, containers
 	return nil
 }
 
+// ConfigureServicePKIByContainerName modify the PodSpec adding cert the volumes and volumeMounts to the specified containers.
+func ConfigureServicePKIByContainerName(tempoStackName string, component string, podSpec *corev1.PodSpec, containers ...string) error {
+	targetContainers := map[string]struct{}{}
+	for _, name := range containers {
+		targetContainers[name] = struct{}{}
+	}
+	ids := []int{}
+	for id, c := range podSpec.Containers {
+		if _, exists := targetContainers[c.Name]; exists {
+			ids = append(ids, id)
+		}
+	}
+	return ConfigureServicePKI(tempoStackName, component, podSpec, ids...)
+}
+
 // ConfigureServicePKI modify the PodSpec adding cert the volumes and volumeMounts to the specified containers.
 func ConfigureServicePKI(tempoStackName string, component string, podSpec *corev1.PodSpec, containers ...int) error {
 	serviceName := naming.TLSSecretName(component, tempoStackName)

diff --git a/internal/manifests/queryfrontend/query_frontend.go b/internal/manifests/queryfrontend/query_frontend.go
@@ -54,21 +54,12 @@ func BuildQueryFrontend(params manifestutils.Params) ([]client.Object, error) {
 
 	if gates.HTTPEncryption || gates.GRPCEncryption {
 		caBundleName := naming.SigningCABundleName(tempo.Name)
-		targetContainers := map[string]struct{}{
-			containerNameTempo:      {},
-			containerNameTempoQuery: {},
-		}
-		targets := []int{}
-		for i, c := range d.Spec.Template.Spec.Containers {
-			if _, exists := targetContainers[c.Name]; exists {
-				targets = append(targets, i)
-			}
-		}
-		if err := manifestutils.ConfigureServiceCA(&d.Spec.Template.Spec, caBundleName, targets...); err != nil {
+		targets := []string{containerNameTempo, containerNameTempoQuery}
+		if err := manifestutils.ConfigureServiceCAByContainerName(&d.Spec.Template.Spec, caBundleName, targets...); err != nil {
 			return nil, err
 		}
 
-		err := manifestutils.ConfigureServicePKI(tempo.Name, manifestutils.QueryFrontendComponentName, &d.Spec.Template.Spec, targets...)
+		err := manifestutils.ConfigureServicePKIByContainerName(tempo.Name, manifestutils.QueryFrontendComponentName, &d.Spec.Template.Spec, targets...)
 		if err != nil {
 			return nil, err
 		}