Skip to content

Commit

Permalink
[TraceQL] Remove unnecessary spanset layer, iterators, and predicates (
Browse files Browse the repository at this point in the history
…#2961)

* Remove intermediate spanset layer. Various other cleanups

* Use static intrinsic attributes in traceql package

* Apply updates to vParquet2

* Switch back to faster type checks

* Replace other key checks with type checks

* Apply same updates to vParquet2

* comment
  • Loading branch information
mdisibio authored Oct 3, 2023
1 parent b8b8296 commit 1537a1e
Show file tree
Hide file tree
Showing 3 changed files with 240 additions and 202 deletions.
12 changes: 12 additions & 0 deletions pkg/traceql/enum_attributes.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,18 @@ const (
IntrinsicSpanStartTime
)

var (
IntrinsicDurationAttribute = NewIntrinsic(IntrinsicDuration)
IntrinsicNameAttribute = NewIntrinsic(IntrinsicName)
IntrinsicStatusAttribute = NewIntrinsic(IntrinsicStatus)
IntrinsicStatusMessageAttribute = NewIntrinsic(IntrinsicStatusMessage)
IntrinsicKindAttribute = NewIntrinsic(IntrinsicKind)
IntrinsicChildCountAttribute = NewIntrinsic(IntrinsicChildCount)
IntrinsicTraceRootServiceAttribute = NewIntrinsic(IntrinsicTraceRootService)
IntrinsicTraceRootSpanAttribute = NewIntrinsic(IntrinsicTraceRootSpan)
IntrinsicTraceDurationAttribute = NewIntrinsic(IntrinsicTraceDuration)
)

func (i Intrinsic) String() string {
switch i {
case IntrinsicNone:
Expand Down
Loading

0 comments on commit 1537a1e

Please sign in to comment.