Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Rhythm ingest path #4314

Merged
merged 7 commits into from
Nov 19, 2024
Merged

Conversation

mdisibio
Copy link
Contributor

@mdisibio mdisibio commented Nov 12, 2024

What this PR does:
Main focus is making everything work in SingleBinary mode for easy debugging.

  • Assume partition 0 without need to configure block builder assigned partitions or host name to include a parseable number
  • Fix block-builder startup error where the block builder caused a module failure before the ingester had time to create the partition. This was because the block-builder was treating a consumeCycle error as a hard module failure. Now it keeps retrying on a timer.
  • Validate config on startup, to make missing fields more clear
  • Repair tests

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

modules/blockbuilder/blockbuilder.go Outdated Show resolved Hide resolved
@mdisibio mdisibio merged commit 2b4e1fb into grafana:rhythm Nov 19, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants