Make deploy.RunPod
wait for pod readiness rather than running phase
#346
+121
−52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the
WaitPodRunning
function toWaitPodReady
, which checks whether the pod has theReady
condition set toTrue
instead of simply being in theRunning
phase.If a pod does not contain any container with a readiness probe defined,
WaitPodReady
should behave exactly the same asWaitPodRunning
did. However, if one or more containers have a readiness probe,WaitPodReady
will wait until they are satisfied.This is helpful to reduce flakiness on certain tests which previously attempted to initiate a connection to a pod once it was running, but before the pod had time to actually get started. By attaching a readiness probe to those pods, this scenario can be avoided, as
deploy.RunPod
will wait or error until the readiness probe passes.This PR also adds a helper
WithHTTPReadinessProbe
function toContainerBuilder
, that attaches an HTTP GET readiness probe to a container with reasonable defaults.Checklist:
make lint
) and all checks pass.make test
) and all tests pass.make integration-xxx
for affected packages)make e2e-xxx
fordisruptors
, orcluster
related changes)