Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX-11: Fix breaking cmd.exe on windows platform #14

Merged
merged 7 commits into from
Nov 23, 2023
Merged

Conversation

grafviktor
Copy link
Owner

@grafviktor grafviktor commented Nov 21, 2023

cmd.exe ui breaks if instead of typing password when connecting to a remote host, type ctrl+c. It requires to restart the application to restore terminal functionality.

@grafviktor grafviktor added the bug Something isn't working label Nov 21, 2023
@grafviktor grafviktor added this to the v0.3.0 milestone Nov 21, 2023
@grafviktor grafviktor self-assigned this Nov 21, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (41df624) 0.00% compared to head (d3f8dc4) 52.74%.

Files Patch % Lines
internal/utils/ssh/cmd_nix.go 0.00% 2 Missing ⚠️
internal/utils/ssh/cmd_win.go 0.00% 2 Missing ⚠️
internal/utils/ssh/connect.go 93.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop      #14       +/-   ##
============================================
+ Coverage         0   52.74%   +52.74%     
============================================
  Files            0        4        +4     
  Lines            0       91       +91     
============================================
+ Hits             0       48       +48     
- Misses           0       43       +43     
Flag Coverage Δ
go-1.19.x 52.74% <88.88%> (?)
go-1.20.x 52.74% <88.88%> (?)
macOS 53.93% <92.30%> (?)
ubuntu 53.93% <92.30%> (?)
unit 52.74% <88.88%> (?)
windows 53.93% <92.30%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grafviktor grafviktor merged commit 6f25b1c into develop Nov 23, 2023
9 checks passed
@grafviktor grafviktor deleted the bugfix/11 branch November 25, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows OS terminal (cmd.exe) breaks when ssh process exits with non-zero code
1 participant