Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX-11: Fix constructing connect command #21

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Conversation

grafviktor
Copy link
Owner

Spread operator is missing when pass set of ssh parameters to ssh build command functions. See line 246, ignore all other changes.

@grafviktor grafviktor added the bug Something isn't working label Nov 25, 2023
@grafviktor grafviktor added this to the v0.3.0 milestone Nov 25, 2023
@grafviktor grafviktor self-assigned this Nov 25, 2023
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (1082609) 9.94% compared to head (e853e6c) 9.96%.

Files Patch % Lines
internal/ui/component/hostlist/list.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop     #21      +/-   ##
==========================================
+ Coverage     9.94%   9.96%   +0.02%     
==========================================
  Files           20      19       -1     
  Lines          855     853       -2     
==========================================
  Hits            85      85              
+ Misses         765     763       -2     
  Partials         5       5              
Flag Coverage Δ
go-1.19.x 9.96% <0.00%> (+0.02%) ⬆️
go-1.20.x 65.81% <ø> (+1.10%) ⬆️
macOS 9.96% <0.00%> (ø)
ubuntu 9.96% <0.00%> (ø)
unit 9.96% <0.00%> (+0.02%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grafviktor grafviktor merged commit 5beec3d into develop Nov 25, 2023
7 of 9 checks passed
@grafviktor grafviktor deleted the bugfix/11-2 branch November 26, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows OS terminal (cmd.exe) breaks when ssh process exits with non-zero code
1 participant