Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMPROVEMENT-12: Add code comments. Adjust unit tests. #22

Merged
merged 2 commits into from
Nov 25, 2023

Conversation

grafviktor
Copy link
Owner

No description provided.

@grafviktor grafviktor added the feature New feature or request label Nov 25, 2023
@grafviktor grafviktor added this to the v0.3.0 milestone Nov 25, 2023
@grafviktor grafviktor self-assigned this Nov 25, 2023
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (5beec3d) 9.94% compared to head (b6189d6) 10.38%.

Files Patch % Lines
internal/logger/logger.go 0.00% 8 Missing ⚠️
internal/ui/component/edithost/label_input.go 0.00% 6 Missing ⚠️
internal/config/config.go 0.00% 3 Missing ⚠️
internal/ui/component/edithost/edit_host.go 0.00% 2 Missing ⚠️
internal/state/state.go 0.00% 1 Missing ⚠️
internal/storage/yaml_storage.go 0.00% 1 Missing ⚠️
internal/ui/component/hostlist/list_item.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #22      +/-   ##
===========================================
+ Coverage     9.94%   10.38%   +0.44%     
===========================================
  Files           20       20              
  Lines          855      857       +2     
===========================================
+ Hits            85       89       +4     
+ Misses         765      763       -2     
  Partials         5        5              
Flag Coverage Δ
go-1.19.x 10.17% <4.34%> (+0.23%) ⬆️
go-1.20.x 68.06% <100.00%> (+3.36%) ⬆️
macOS 10.17% <4.34%> (+0.21%) ⬆️
ubuntu 10.17% <4.34%> (+0.21%) ⬆️
unit 10.38% <4.34%> (+0.44%) ⬆️
windows 82.29% <100.00%> (+2.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grafviktor grafviktor merged commit b3b9279 into develop Nov 25, 2023
8 of 9 checks passed
@grafviktor grafviktor deleted the improvement/12-5 branch November 25, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant