Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMPROVEMENT-35: Improve application logging #46

Merged
merged 11 commits into from
Jan 30, 2024
Merged

Conversation

grafviktor
Copy link
Owner

The log file should reflect application life cycle and show full user interaction story.

In progress.

@grafviktor grafviktor added the feature New feature or request label Jan 22, 2024
@grafviktor grafviktor self-assigned this Jan 22, 2024
@grafviktor grafviktor linked an issue Jan 22, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 56 lines in your changes are missing coverage. Please review.

Comparison is base (2eb8821) 62.87% compared to head (37247b5) 65.96%.

Files Patch % Lines
internal/storage/yaml_storage.go 0.00% 26 Missing ⚠️
internal/ui/main.go 0.00% 12 Missing ⚠️
internal/ui/component/hostlist/list.go 64.28% 10 Missing ⚠️
internal/state/state.go 62.50% 3 Missing ⚠️
internal/config/config.go 0.00% 2 Missing ⚠️
internal/ui/component/edithost/edit_host.go 83.33% 2 Missing ⚠️
internal/ui/init_nix.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #46      +/-   ##
===========================================
+ Coverage    62.87%   65.96%   +3.08%     
===========================================
  Files           20       20              
  Lines         1021     1087      +66     
===========================================
+ Hits           642      717      +75     
+ Misses         365      354      -11     
- Partials        14       16       +2     
Flag Coverage Δ
go-1.19.x 65.96% <37.77%> (+3.08%) ⬆️
go-1.20.x 73.46% <44.15%> (+3.60%) ⬆️
macOS 65.89% <37.77%> (+3.09%) ⬆️
ubuntu 65.89% <37.77%> (+3.09%) ⬆️
unit 65.96% <37.77%> (+3.08%) ⬆️
windows 84.24% <69.38%> (+5.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grafviktor grafviktor merged commit 3f98e42 into develop Jan 30, 2024
8 of 9 checks passed
@grafviktor grafviktor deleted the improvement/35 branch January 30, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve logging
1 participant