Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update multipleDatasources.adoc #888

Open
wants to merge 1 commit into
base: 6.1.x
Choose a base branch
from
Open

Update multipleDatasources.adoc #888

wants to merge 1 commit into from

Conversation

kovacicluka
Copy link

As in org.grails.plugins.datasource.DataSourceGrailsPlugin, configuration name is grails.transaction.chainedTransactionManager.

@kovacicluka
Update multipleDatasources.adoc
a93ea63 
As in org.grails.plugins.datasource.DataSourceGrailsPlugin, configuration name is `grails.transaction.chainedTransactionManager`.
@CLAassistant
Copy link

CLAassistant commented Mar 27, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@puneetbehl
Copy link
Contributor

Please sign the CLA.

@kovacicluka
Copy link
Author

Please sign the CLA.

I did, when I clicked again on "CLA not signed yet" I got "You have agreed to the CLA for grails/grails-doc"

matrei
matrei requested changes Aug 11, 2024
View reviewed changes
Copy link
Contributor

@matrei matrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! There are actually two more places where chainedTransactionManagerPostProcessor should be changed.

grails-doc/src/en/guide/conf/dataSource/multipleDatasources.adoc

Line 248 in 0da43fe

You can enable Grails to use the Best Effort 1PC pattern for handling transactions across multiple datasources. To do so you must set the `grails.transaction.chainedTransactionManagerPostProcessor.enabled` setting to `true` in `application.yml`:

grails-doc/src/en/guide/conf/dataSource/multipleDatasources.adoc

Line 254 in 0da43fe

chainedTransactionManagerPostProcessor:

Would you mind changing these as well in this PR?

@grails grails deleted a comment from CLAassistant Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matrei matrei matrei requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kovacicluka @CLAassistant @puneetbehl @matrei