Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to_data and data method in all Action class , use attribute dict #89

Open
yck011522 opened this issue Sep 10, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request ITJ_Library Core ITJ Library / Geometry / Assembly / Process low_priority

Comments

@yck011522
Copy link
Member

It would be good refactor the attribute storing method of the Action classes to be similar to the compas.datastructures attributes dictionary. Where the base class Action serialize the attributes dictionary, child classes can simply write getter and setter that points to an entry in that dictionary.

It will have a cleaner class signature, avoids each child class managing a chain of overriding data() while still having to call super class's data(). Especially in multiple inheritance scenarios.

@yck011522 yck011522 added enhancement New feature or request ITJ_Library Core ITJ Library / Geometry / Assembly / Process low_priority labels Sep 10, 2021
@yck011522 yck011522 self-assigned this Sep 10, 2021
@yck011522 yck011522 changed the title Refactor to_data and data method in all Action class for easier maintenance Refactor to_data and data method in all Action class , use attribute dict Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ITJ_Library Core ITJ Library / Geometry / Assembly / Process low_priority
Projects
None yet
Development

No branches or pull requests

1 participant