Report simpler Python version string in About and Error dialogs #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A gramps user reported on the discourse forum that information in the about box was truncated, and he could not expand the box to view the rest of the text. A look at the text in question suggested a simple change: the truncated string is intended to be the Python version which is typically major.minor.patch version, but the text being displayed is the output of sys.version() which includes additional information including build number and compiler used. For the About box this isn't necessarily useful, so this PR replaces that call with platform.python_version() which returns just the version and resolves the truncated string issue. The same change is also made in the error report dialog for consistency.
Nick-Hall
force-pushed
the
aboutbox-python-ver-gramps52
branch
from
be8e476 to
60823e7
Compare
Please open a separate PR for the unrelated change. |
Nick-Hall
force-pushed
the
aboutbox-python-ver-gramps52
branch
from
60823e7 to
b0fb4f7
Compare
Nick-Hall
merged commit b0fb4f7
into
gramps-project:maintenance/gramps52
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A gramps user reported on the discourse forum (thread) that information in the about box was truncated, and he could not expand the box to view the rest of the text.
A look at the text in question suggested a simple change: the truncated string is intended to be the Python version which is typically major.minor.patch version, but the text being displayed is the output of sys.version() which includes additional information including build number and compiler used. For the About box this isn't necessarily useful, so this PR replaces that call with platform.python_version() which returns just the version and resolves the truncated string issue. The same change is also made in the error report dialog for consistency.
An unrelated change is also included in this PR: after building the AIO bundle locally several artifacts are generated (or downloaded) to the source folder, which have been added to .gitignore to avoid tracking with git.
Here's what the Python strings look like with the change:
FYI @emyoulation