Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cx-freeze 7.2.8.1 #1929

Conversation

stevenyoungs
Copy link
Contributor

The latest cx-freeze version 7.2.9.[1|2] result in two DLLs being located in the wrong directory.

  1. force use of cx-freeze 7.2.8.1 which works correctly
  2. update pacman databases as part of the build to ensure local builds match runners

Fixes bug 0013602

@stevenyoungs
Copy link
Contributor Author

@Nick-Hall can you run the AIO workflow on this branch, or give me permissions to do so?

@Nick-Hall Nick-Hall added the bug label Feb 5, 2025
@stevenyoungs stevenyoungs changed the title Bug: Use cx-freeze 7.2.8.1 Use cx-freeze 7.2.8.1 Feb 5, 2025
@Nick-Hall
Copy link
Member

I've uploaded a new version to the release page.

You can link to this PR in Mantis BT with p:gramps:1929:

@stevenyoungs
Copy link
Contributor Author

I've uploaded a new version to the release page.

You can link to this PR in Mantis BT with p:gramps:1929:

👍 I couldn't get Mantis links to work - as you probably saw!

I downloaded the installer GrampsAIO-6.0.0-r1-ba2c71f_win64.exe direct from the workflow artifacts. It installs OK, and Gramps starts correctly from the Start Menu

@Nick-Hall Nick-Hall added this to the v6.0 milestone Feb 6, 2025
@Nick-Hall
Copy link
Member

I notice that cx-Freeze 7.2.10 has just been released.

Please try GrampsAIO-6.0.0-beta1-3_win64.exe from the release page.

@stevenyoungs
Copy link
Contributor Author

I notice that cx-Freeze 7.2.10 has just been released.

Please try GrampsAIO-6.0.0-beta1-3_win64.exe from the release page.

That starts OK. Gramps reports itself as "AIO64-6.0.0-r1-5a76f63"
It would have saved a lot of time if they had released 24 hours earlier. Oh well.

@Nick-Hall
Copy link
Member

Gramps really should report itself as "GrampsAIO-6.0.0-beta1-3".

If you look in the Debian workflow we can enter a build number. If the release is a development release we use the Git SHA otherwise we use the build number. The "beta1" is also missing.

@Nick-Hall
Copy link
Member

I'll close this PR now since it is no longer required.

@Nick-Hall Nick-Hall closed this Feb 6, 2025
@stevenyoungs
Copy link
Contributor Author

Gramps really should report itself as "GrampsAIO-6.0.0-beta1-3".

It's not a new problem. The official 5.2.3 shows "AIO64-5.2.3-r1-aa03f5a" is Help > About

@Nick-Hall
Copy link
Member

It would be much better if it showed the actual version including the qualifier and build number.

@lordemannd
Copy link
Contributor

AIO64-6.0.0-r1-5a76f63 is working for me. good job.

versioning: a small thing, but, at least for this beta test phase of rapid changes,
can the name of the installer match the version string we are actually using (and visible under Help) ?
i.e. GrampsAIO-6.0.0-beta1-3_win64.exe be called something like GrampsAIO-6.0.0-r1-5a76f63_win64.exe,
or even just GrampsAIO64-6.0.0-r1-5a76f63.exe

@lordemannd
Copy link
Contributor

lordemannd commented Feb 7, 2025

versioning: OOPS: I forgot Mantis, it still doesn't match up with the version strings there.

@Nick-Hall
Copy link
Member

can the name of the installer match the version string we are actually using (and visible under Help) ?

See PR #1935.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants