Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a better description of development versions #1938

Closed

Conversation

Nick-Hall
Copy link
Member

@Nick-Hall Nick-Hall commented Feb 7, 2025

Use git describe to provide the version text for development versions.

Before this change:

> python Gramps.py -v
6.0.0-beta2-149fb610ca

After the change:

> python Gramps.py -v
v6.0.0-beta1-28-g0abc833f08

@Nick-Hall Nick-Hall added the bug label Feb 7, 2025
@Nick-Hall Nick-Hall added this to the v6.0 milestone Feb 7, 2025
@Nick-Hall Nick-Hall force-pushed the git-revision branch 2 times, most recently from 2a046b7 to 1464074 Compare February 7, 2025 19:35
@stevenyoungs
Copy link
Contributor

stevenyoungs commented Feb 7, 2025

By default the workflow checkout action only fetches a single commit. See https://github.com/actions/checkout/blob/v4/README.md

Therefore git describe won't provide a useful result

Use `git describe` to provide the version text for development
versions.
@Nick-Hall
Copy link
Member Author

The output isn't very useful on the master branch, maybe git describe could still be a good way to get the commit hash.

@Nick-Hall Nick-Hall closed this Feb 11, 2025
@Nick-Hall
Copy link
Member Author

I'm closing this because it doesn't give much benefit, and isn't useful on the master branch.

@Nick-Hall Nick-Hall removed this from the v6.0 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants