Skip to content

Commit

Permalink
[build][msvc] Ignore fallthrough-ignored warning
Browse files Browse the repository at this point in the history
The attribute is only introduced in C++17 and we specify C++14. But it
still conveys the intention well, even if the compiler ignores it.
  • Loading branch information
grandchild committed Nov 2, 2024
1 parent 52f7316 commit a886a08
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
/wd4244 # Ignore warning about type conversions with data loss.
# They are simply too many at the moment and obscure other
# warnings. TODO[cleanup]: Reenable and fix warnings.
/wd5051 # Ignore warning that [[fallthrough]] is ignored on C++<17.
# It's still useful for readability.
/MP # Multithreaded compilation
/std:c++14 # Pin to C++14 features
/Zc:__cplusplus # Define the actual C++ standard in __cplusplus, instead of
Expand Down

0 comments on commit a886a08

Please sign in to comment.