join sentences with a whitespace #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankushshah89
changed the title
ankushshah89
changed the title
|
the test is failing. will look into it and then reopen |
|
only the test_donga_korean is failing. I looked at the expected in the test and even it has the same problem. The expected value doesn't have spaces after "." (period) in some of the sentences. Though, I have no idea about Korean but I guess there should always be space after every ".". So, may be the test case needs to be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Join the replacetext with a whitespace. Otherwise two different sentence can be mixed. For eg:
url = http://timesofindia.indiatimes.com/tech/tech-news/Facebooks-Mark-Zuckerberg-in-India-today/articleshow/44740431.cms
from goose import Goose
g = Goose()
a = g.extract(url)
a.cleaned_text
u'NEW DELHI: Facebook co-founder Mark Zuckerberg willon Thursday attend the two-day long Internet.org summit that aims to make internet access affordable for people who do not have it globally.Zuckerberg......'
Notice that there is no space between two sentences. This creates problem when later on, we want to split the cleaned_text using some sentence tokenizer.