Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Bandit json parser #44

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nandusekarv10
Copy link

I am 1st time contributor to open source project. Please let me know if I have to make any changes.

@nandusekarv10 nandusekarv10 marked this pull request as ready for review January 13, 2021 23:27
@nandusekarv10 nandusekarv10 force-pushed the vn-adding-bandit-parser-to-lintly branch 5 times, most recently from c6f3470 to d02ee8e Compare January 14, 2021 00:15
@nandusekarv10 nandusekarv10 force-pushed the vn-adding-bandit-parser-to-lintly branch from d02ee8e to 362678b Compare January 14, 2021 00:41
@nandusekarv10
Copy link
Author

@grantmcconnaughey Could you please review this?

@scriptsrc
Copy link

Hey @grantmcconnaughey - I believe this PR is all cleaned up and ready to go now.

Thanks for Lintly. It's a pretty cool library.

In parallel we're working on a cfn_nag action that uses lintly (based on your flake8 action). It's not quite ready but hopefully it will be soon.
https://github.com/23andMe/lintly-cfn-nag-github-action

@scriptsrc
Copy link

Hey @grantmcconnaughey,

Sorry to bug you about this PR. I also maintain an OSS package so I totally understand how much work it is and how thankless it can often be.

Let us know how we can support you. We can fix any style or code quality issues. Thanks for this awesome project.

…-lt-3.0

Update python-gitlab requirement from <2.0 to <3.0
Update click requirement from <7.0 to <8.0
@scriptsrc
Copy link

Merging this into our own fork of Lintly:

https://github.com/23andme/lintly
https://pypi.org/project/ttam-lintly/

The idea is that we can stop bugging Grant and still use his wonderful library. Thanks man.

@grantmcconnaughey
Copy link
Owner

Apologies for the delay, folks. I'll get this merged and pushed to PyPI this week.

This is also making me think Lintly could benefit from a plug-in system. Something that lets folks add their own formatters without needing to merge them into the main Lintly codebase. 🤔

@renefritze renefritze mentioned this pull request Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants