Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] recurring_consignment: #187

Conversation

legalsylvain
Copy link
Member

  • Add properties on partner
  • add company on demo product to avoid multi company error
  • fix typo

@legalsylvain legalsylvain added this to the 16.0 milestone Feb 19, 2025
@legalsylvain
Copy link
Member Author

/ocabot merge patch

on tente de fast merger. peut-etre que ça va résoudre ce machin à cul.

#145

@github-grap-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-187-by-legalsylvain-bump-patch, awaiting test results.

github-grap-bot added a commit that referenced this pull request Feb 19, 2025
Signed-off-by legalsylvain
@github-grap-bot
Copy link
Contributor

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-187-by-legalsylvain-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

1 similar comment
@github-grap-bot
Copy link
Contributor

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-187-by-legalsylvain-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

- Add properties on partner
- add company on demo product to avoid multi company error
- Harmonize Currency setting in test
- fix typo
@legalsylvain legalsylvain force-pushed the 16.0-FIX-recurring_consignment-demo-property branch from 3e51126 to 326da29 Compare February 19, 2025 16:06
@legalsylvain
Copy link
Member Author

/ocabot merge patch

@github-grap-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-187-by-legalsylvain-bump-patch, awaiting test results.

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (6c166fc) to head (326da29).
Report is 3 commits behind head on 16.0.

Additional details and impacted files
@@           Coverage Diff           @@
##             16.0     #187   +/-   ##
=======================================
  Coverage   90.05%   90.06%           
=======================================
  Files         119      119           
  Lines        1408     1409    +1     
  Branches      129      129           
=======================================
+ Hits         1268     1269    +1     
  Misses        103      103           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-grap-bot github-grap-bot merged commit b52eb7d into grap:16.0 Feb 19, 2025
4 checks passed
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at 63b9525. Thanks a lot for contributing to grap. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants