Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] product_print_category: Use different report container to make barcodes show up #124

Open
wants to merge 1 commit into
base: 12.0
Choose a base branch
from

Conversation

leonhandreke
Copy link

I am facing the issue described here:
https://www.odoo.com/forum/help-1/cannot-print-barcodes-on-pdf-reports-149885

In short: the barcodes do not show up. Not sure what the issue is, but
part of the fix is calling web.basic_layout instead of
web.html_container in the report template. I don't know why this
helps, but it does.

…barcodes show up

I am facing the issue described here:
https://www.odoo.com/forum/help-1/cannot-print-barcodes-on-pdf-reports-149885

In short: the barcodes do not show up. Not sure what the issue is, but
part of the fix is calling `web.basic_layout` instead of
`web.html_container` in the report template. I don't know why this
helps, but it does.
@leonhandreke
Copy link
Author

@legalsylvain tagging you since you are the author of this module and probably know better what's happening here than I do. Merci!

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #124 (53dc5aa) into 12.0 (41d424f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             12.0     #124   +/-   ##
=======================================
  Coverage   72.80%   72.80%           
=======================================
  Files          70       70           
  Lines        1585     1585           
=======================================
  Hits         1154     1154           
  Misses        431      431           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41d424f...53dc5aa. Read the comment docs.

@legalsylvain
Copy link
Member

Hi @leonhandreke. Thanks for reporting and fixing. I just fear that changing the layout change margin.
I'll do some test in the next days and will report you if all is ok.

kind regards.

CC : @quentinDupont

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants