Fixing test for product-attribute/base_product_mass_addition #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzPoize
force-pushed
the
16.0-mig-base_product_mass_addition
branch
from
6d1499b
to
52bb420
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
FranzPoize
force-pushed
the
16.0-mig-base_product_mass_addition
branch
from
52bb420
to
8ae6c07
Compare
legalsylvain
merged commit e32dfb5
into
grap:16.0-mig-base_product_mass_addition
4 of 6 checks passed
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @legalsylvain, I fixed the test for this as said in the original PR it is not possible to write to write_uid so by some trickery we can check the write_date to check if flush_model passes in the write method of the model