bug fix #348

graphhopper · Jul 17, 2023 · 349bcd8 · 349bcd8
1 parent d6155e8
commit 349bcd8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/src/Converters.ts b/src/Converters.ts
@@ -2,13 +2,13 @@ import { GeocodingHit } from '@/api/graphhopper'
 
 import { Coordinate } from '@/stores/QueryStore'
 
-export function milliSecondsToText(seconds: number) {
-    const hours = Math.floor(seconds / 3600000)
-    const minutes = Math.floor((seconds % 3600000) / 60000)
+export function milliSecondsToText(ms: number) {
+    const hours = Math.floor(ms / 3600000)
+    const minutes = Math.round((ms % 3600000) / 60000)
 
     const hourText = hours > 0 ? hours + ' h' : ''
     if (minutes == 0 && hourText.length > 0) return hourText
-    return hourText + ' ' + minutes + ' min'
+    return (hourText ? hourText + ' ' : '') + minutes + ' min'
 }
 
 const distanceFormat = new Intl.NumberFormat(navigator.language, { maximumFractionDigits: 1 })

diff --git a/test/Converters.test.ts b/test/Converters.test.ts
@@ -1,7 +1,14 @@
-import { textToCoordinate, nominatimHitToItem, hitToItem } from '@/Converters'
-import { GeocodingHit } from '@/api/graphhopper'
+import { textToCoordinate, nominatimHitToItem, hitToItem, milliSecondsToText } from '@/Converters'
 
 describe('Converters', function () {
+    describe('milliSecondsToText', function () {
+        it('should convert ms to text', function () {
+            expect(milliSecondsToText(59 * 1000)).toEqual('1 min')
+
+            expect(milliSecondsToText(63 * 60 * 1000)).toEqual('1 h 3 min')
+        })
+    })
+
     describe('textToCoordinate', function () {
         it('should convert 2 digits separated by ","', function () {
             expect(textToCoordinate('1.2345, 2.6534')).toEqual({ lat: 1.2345, lng: 2.6534 })