WIP: handling viterbi breaks as multiple sequences

matching-core/src/main/java/com/graphhopper/matching/GPXExtension.java → matching-core/src/main/java/com/graphhopper/matching/Candidate.java

@@ -38,17 +38,32 @@
  * @author kodonnell
  * @author Stefan Holder
  */
-public class GPXExtension {
+public class Candidate {
+    /**
+     * The original GPX entry for which this candidate is for.
+     */
     private final GPXEntry entry;
+    /**
+     * The QueryResult defining this candidate location.
+     */
     private final QueryResult queryResult;
+    /**
+     * Flag for whether or not this is a directed candidate.
+     */
     private final boolean isDirected;
+    /**
+     * The virtual edge that should be used by incoming paths.
+     */
     private final EdgeIteratorState incomingVirtualEdge;
+    /**
+     * The virtual edge that should be used by outgoing paths.
+     */
     private final EdgeIteratorState outgoingVirtualEdge;
 
     /**
      * Creates an undirected candidate for a real node.
      */
-    public GPXExtension(GPXEntry entry, QueryResult queryResult) {
+    public Candidate(GPXEntry entry, QueryResult queryResult) {
         this.entry = entry;
         this.queryResult = queryResult;
         this.isDirected = false;
@@ -59,7 +74,7 @@ public GPXExtension(GPXEntry entry, QueryResult queryResult) {
     /**
      * Creates a directed candidate for a virtual node.
      */
-    public GPXExtension(GPXEntry entry, QueryResult queryResult,
+    public Candidate(GPXEntry entry, QueryResult queryResult,
                         VirtualEdgeIteratorState incomingVirtualEdge,
                         VirtualEdgeIteratorState outgoingVirtualEdge) {
         this.entry = entry;

matching-core/src/main/java/com/graphhopper/matching/GPXFile.java

@@ -51,7 +51,7 @@ public class GPXFile {
     static final String DATE_FORMAT_Z_MS = "yyyy-MM-dd'T'HH:mm:ss.SSS'Z'";
     private final List<GPXEntry> entries;
     private boolean includeElevation = false;
-    private InstructionList instructions;
+    private List<InstructionList> instructions;
 
     public GPXFile() {
         entries = new ArrayList<GPXEntry>();
@@ -61,14 +61,14 @@ public GPXFile(List<GPXEntry> entries) {
         this.entries = entries;
     }
 
-    public GPXFile(MatchResult mr, InstructionList il) {
+    public GPXFile(MatchResult mr, List<InstructionList> il) {
         this.instructions = il;
         this.entries = new ArrayList<GPXEntry>(mr.getEdgeMatches().size());
         // TODO fetch time from GPX or from calculated route?
         long time = 0;
         for (int emIndex = 0; emIndex < mr.getEdgeMatches().size(); emIndex++) {
-            EdgeMatch em = mr.getEdgeMatches().get(emIndex);
-            PointList pl = em.getEdgeState().fetchWayGeometry(emIndex == 0 ? 3 : 2);
+            MatchEdge em = mr.getEdgeMatches().get(emIndex);
+            PointList pl = em.edge.fetchWayGeometry(emIndex == 0 ? 3 : 2);
             if (pl.is3D()) {
                 includeElevation = true;
             }
@@ -198,17 +198,20 @@ public String createString() {
         StringBuilder gpxOutput = new StringBuilder(header);
         gpxOutput.append("\n<trk><name>").append("GraphHopper MapMatching").append("</name>");
 
+        // TODO: is this correct? how do we know there's a 'gap' in the instructions i.e. multiple
+        // sequences? Do instructions only make sense for a single sequence?
         if (instructions != null && !instructions.isEmpty()) {
             gpxOutput.append("\n<rte>");
-            Instruction nextInstr = null;
-            for (Instruction currInstr : instructions) {
-                if (null != nextInstr) {
-                    instructions.createRteptBlock(gpxOutput, nextInstr, currInstr);
+            for (InstructionList instr: instructions) {
+                Instruction nextInstr = null;
+                for (Instruction currInstr : instr) {
+                    if (null != nextInstr) {
+                        instr.createRteptBlock(gpxOutput, nextInstr, currInstr);
+                    }
+                    nextInstr = currInstr;
                 }
-
-                nextInstr = currInstr;
+                instr.createRteptBlock(gpxOutput, nextInstr, null);
             }
-            instructions.createRteptBlock(gpxOutput, nextInstr, null);
             gpxOutput.append("\n</rte>");
         }