Provide access to underlying model during build/update/save process closer mirroring rails patterns #465
+141
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkeen
force-pushed
the
feature/data-access
branch
from
fec4590
to
2882008
Compare
jkeen
force-pushed
the
feature/data-access
branch
3 times, most recently
from
5d66f76
to
bbacf6f
Compare
jkeen
force-pushed
the
feature/data-access
branch
from
bbacf6f
to
26a3820
Compare
…closer mirroring rails controller patterns. Changes: - (for creates): @resource = MyResource.build(params); @resource.data #=> unsaved model with attributes applied - (for updates): @resource = MyResource.find(params); @resource.assign_attributes @resource.data #=> unsaved model with attributes applied
… for possible compatibility issues
jkeen
force-pushed
the
feature/data-access
branch
from
26a3820
to
8997e49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made these updates long ago and have been using them on a private branch. There might still be edge cases I'm not considering, so I'm starting this PR as a place to consider it.
Changes: