Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tap-agent): never log config #258

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

aasseman
Copy link
Contributor

We are currently printing the contents of the config in the logs at the debug level. While that was useful at early testing stage, we should now drop it before it gets used on mainnet.

We are currently printing the contents of the config in the logs
at the debug level. While that was useful at early testing stage, 
we should now drop it before it gets used on mainnet.
@aasseman aasseman self-assigned this Jul 26, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10104522230

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 65.99%

Totals Coverage Status
Change from base Build 10101421574: 0.01%
Covered Lines: 3867
Relevant Lines: 5860

💛 - Coveralls

Copy link
Member

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aasseman aasseman merged commit ead4ac2 into main Jul 26, 2024
10 checks passed
@aasseman aasseman deleted the aasseman/dont-print-config branch July 26, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants