Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Accept config to be through file or env vars #352

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

carlosvdr
Copy link
Collaborator

fixes #337

@carlosvdr carlosvdr self-assigned this Oct 7, 2024
@carlosvdr
Copy link
Collaborator Author

So I didnt added it, as in the validation it should fail so didnt saw a reason to add it.

But maybe also add to first validate the env vars, and if they are not all okay to error out a file name is alaso required?

@coveralls
Copy link

coveralls commented Oct 7, 2024

Pull Request Test Coverage Report for Build 11240998283

Details

  • 17 of 30 (56.67%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 70.515%

Changes Missing Coverage Covered Lines Changed/Added Lines %
config/src/config.rs 17 18 94.44%
service/src/service.rs 0 5 0.0%
tap-agent/src/config.rs 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
tap-agent/src/config.rs 1 4.67%
Totals Coverage Status
Change from base Build 11236095653: -0.06%
Covered Lines: 4556
Relevant Lines: 6461

💛 - Coveralls

config/src/config.rs Outdated Show resolved Hide resolved
service/src/service.rs Outdated Show resolved Hide resolved
gusinacio
gusinacio previously approved these changes Oct 8, 2024
Copy link
Member

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio merged commit 9e44ad4 into main Oct 8, 2024
10 checks passed
@gusinacio gusinacio deleted the remove-config-file-requiremnt branch October 8, 2024 19:58
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove requirement for config file
3 participants