Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common,cli,agent: remove multi-network-mode #1090

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

dwerner
Copy link
Contributor

@dwerner dwerner commented Feb 7, 2025

This PR removes multi-network mode while preserving the network config parsing logic that it was tied to. This enables a significant reduction in complexity.

Changes:

  • Now the agent expects there to only be a single yaml file in the network-specifications-dir
  • If network-specifications-dir is provided then the values are used, otherwise single-network mode's style of pulling values from argv/env are used.
  • Transfer (L1 -> L2) code is removed since the transfer tool is removed now.
  • the env var INDEXER_AGENT_MULTINETWORK_MODE is ignored

@dwerner dwerner force-pushed the fix/remove-multi-network-mode branch from 1070468 to 531a773 Compare February 18, 2025 16:57
@dwerner dwerner force-pushed the fix/remove-multi-network-mode branch from 531a773 to 5e72ec7 Compare February 18, 2025 16:59
@dwerner dwerner requested a review from pcarranzav February 18, 2025 19:32
Copy link
Member

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many red lines, I love it... leaving a few comments for now, but still reviewing

Copy link
Member

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished reviewing, just a couple more details

Copy link
Member

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dwerner dwerner merged commit 4b1726f into main Feb 19, 2025
8 checks passed
@dwerner dwerner deleted the fix/remove-multi-network-mode branch February 19, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚗 Merged
Development

Successfully merging this pull request may close these issues.

2 participants