-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common,cli,agent: remove multi-network-mode #1090
Conversation
b236134
to
29c901e
Compare
1070468
to
531a773
Compare
531a773
to
5e72ec7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So many red lines, I love it... leaving a few comments for now, but still reviewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished reviewing, just a couple more details
packages/indexer-common/src/indexer-management/resolvers/allocations.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
This PR removes multi-network mode while preserving the network config parsing logic that it was tied to. This enables a significant reduction in complexity.
Changes:
network-specifications-dir
network-specifications-dir
is provided then the values are used, otherwise single-network mode's style of pulling values from argv/env are used.