Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: also add chain aliases stripped of their -mainnet suffix #1099

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

dwerner
Copy link
Contributor

@dwerner dwerner commented Feb 21, 2025

This supports shorter network aliases stripped of their -mainnet suffix, if it's present.

@dwerner dwerner marked this pull request as ready for review February 21, 2025 19:30
@dwerner dwerner requested a review from fordN February 21, 2025 19:30
Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@matthewdarwin
Copy link

You could add aliases in the registry instead of having differing list here.

@dwerner
Copy link
Contributor Author

dwerner commented Feb 21, 2025

You could add aliases in the registry instead of having differing list here.

Agreed that would be ideal. I'll loop back around in the future and put in a PR there.

@dwerner dwerner merged commit eb1a786 into main Feb 21, 2025
8 checks passed
@dwerner dwerner deleted the fix/networks-registry-add-aliases-without-suffix branch February 21, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚗 Merged
Development

Successfully merging this pull request may close these issues.

3 participants