Catch panics on hijjacked connection

Catch all panics on hijacked websocket connection so that any middleware that handles panics does not write to the connection.
graphql-editor · Dec 22, 2020 · 264cd04 · 264cd04
1 parent 95293b4
commit 264cd04
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/pkg/handlers/subscription_handler.go b/pkg/handlers/subscription_handler.go
@@ -127,6 +127,11 @@ func (h *Handler) ServeHTTP(rw http.ResponseWriter, req *http.Request) {
 
 	result := graphql.Do(params)
 	if sub, ok := result.Extensions["subscriptionBlocking"].(router.BlockingSubscriptionPayload); ok && len(result.Errors) == 0 {
+		defer func() {
+			if r := recover(); r != nil {
+				klog.Error(r)
+			}
+		}()
 		conn, err := h.upgrader.Upgrade(rw, req, nil)
 		if err != nil {
 			klog.Error(err.Error())