Added support for Core team metrics #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taraspos
reviewed
Mar 20, 2024
| arn_parts = repository_arn.split(':') | ||
| service = arn_parts[2] | ||
| repository_name = arn_parts[5].removeprefix("repository/") | ||
| return get_paginated_results(session, service, "describe_images", "imageDetails", {'repositoryName': repository_name}) |
There was a problem hiding this comment.
@fheinecke did you try by chance list-images call, is it any faster?
There was a problem hiding this comment.
Just tested this. The decrease is negligible and within the margin of error for the tests I ran - around 100us per image. In addition the public ECR endpoint doesn't support list_images, so I'd need to add separate logic for both public and private ECR.
taraspos
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks. Internal tools would like to setup monitoring of some AWS metrics. I stumbled upon this repo while looking for a solution... really glad to see that somebody else already forked this 😀.
I've added a few metrics to monitor AMI quota limits, and ECR quota limits. Both of these have caused major problems when hit during security releases, delaying our releases. These resources have also cost us several hundreds of thousands of dollars when not cleaned up properly. If you guys don't mind owning this code, we'd like to add these metrics.
I have tested these changes locally against the release prod account, and they all work. The ECR image counter metric takes a long time to populate. We have 50k accounts and on my laptop it takes around a minute. We might want to increase the cache TTL. What do you think?