Added support for publishing image to GHCR, and semver tags #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0mant
approved these changes
Apr 12, 2024
Merged
taraspos
approved these changes
Apr 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds GHCR image publishing. This is useful internally so that we don't have to choose between either authenticating with AWS, or getting rate limited. This PR also adds semver tags for published images.
I'll probably file a follow up PR at some point that adds a Helm chart, which will also be pushed to ghcr.
Passing tag event build: https://github.com/gravitational/aws-quota-checker/actions/runs/8667301252/job/23770040440
Passing workflow dispatch event build: https://github.com/gravitational/aws-quota-checker/actions/runs/8667339188/job/23770168528
Passing push event build: https://github.com/gravitational/aws-quota-checker/actions/runs/8667356669/job/23770221471