Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[route53] add 20m cache for calls #43

Merged
merged 3 commits into from
Jul 15, 2024
Merged

[route53] add 20m cache for calls #43

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65ae887
[route53] add 10m cache for calls
taraspos Jul 12, 2024
f21b7e5
increase cache maxsize
taraspos Jul 15, 2024
42084aa
Increase cache ttl
taraspos Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 40 additions & 22 deletions aws_quota/check/route53.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,26 @@
from aws_quota.exceptions import InstanceWithIdentifierNotFound
import typing
import boto3
import cachetools
from .quota_check import InstanceQuotaCheck, QuotaCheck, QuotaScope

# Route53 has quite a low API rate limits, adding cache should reduce throttling rates a bit
# https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/DNSLimitations.html#limits-api-requests

@cachetools.cached(cache=cachetools.TTLCache(maxsize=10, ttl=1200))
def get_route53_account_limits(session: boto3.Session, limit_type: str):
return session.client("route53").get_account_limit(Type=limit_type)


@cachetools.cached(cache=cachetools.TTLCache(maxsize=100, ttl=1200))
def get_route53_hosted_zone_limits(session: boto3.Session, limit_type: str, hosted_zone_id: str):
return session.client("route53").get_hosted_zone_limit(Type=limit_type, HostedZoneId=hosted_zone_id)


@cachetools.cached(cache=cachetools.TTLCache(maxsize=1, ttl=1200))
def list_route53_hosted_zones(session: boto3.Session):
return session.client("route53").list_hosted_zones()["HostedZones"]


class HostedZoneCountCheck(QuotaCheck):
key = "route53_hosted_zone_count"
Expand All @@ -12,11 +30,11 @@ class HostedZoneCountCheck(QuotaCheck):

@property
def maximum(self):
return self.boto_session.client('route53').get_account_limit(Type='MAX_HOSTED_ZONES_BY_OWNER')['Limit']['Value']
return get_route53_account_limits(self.boto_session, "MAX_HOSTED_ZONES_BY_OWNER")["Limit"]["Value"]

@property
def current(self):
return self.boto_session.client('route53').get_account_limit(Type='MAX_HOSTED_ZONES_BY_OWNER')['Count']
return get_route53_account_limits(self.boto_session, "MAX_HOSTED_ZONES_BY_OWNER")["Count"]


class HealthCheckCountCheck(QuotaCheck):
Expand All @@ -27,11 +45,11 @@ class HealthCheckCountCheck(QuotaCheck):

@property
def maximum(self):
return self.boto_session.client('route53').get_account_limit(Type='MAX_HEALTH_CHECKS_BY_OWNER')['Limit']['Value']
return get_route53_account_limits(self.boto_session, "MAX_HEALTH_CHECKS_BY_OWNER")["Limit"]["Value"]

@property
def current(self):
return self.boto_session.client('route53').get_account_limit(Type='MAX_HEALTH_CHECKS_BY_OWNER')['Count']
return get_route53_account_limits(self.boto_session, "MAX_HEALTH_CHECKS_BY_OWNER")["Count"]


class ReusableDelegationSetCountCheck(QuotaCheck):
Expand All @@ -42,11 +60,11 @@ class ReusableDelegationSetCountCheck(QuotaCheck):

@property
def maximum(self):
return self.boto_session.client('route53').get_account_limit(Type='MAX_REUSABLE_DELEGATION_SETS_BY_OWNER')['Limit']['Value']
return get_route53_account_limits(self.boto_session, "MAX_REUSABLE_DELEGATION_SETS_BY_OWNER")["Limit"]["Value"]

@property
def current(self):
return self.boto_session.client('route53').get_account_limit(Type='MAX_REUSABLE_DELEGATION_SETS_BY_OWNER')['Count']
return get_route53_account_limits(self.boto_session, "MAX_REUSABLE_DELEGATION_SETS_BY_OWNER")["Count"]


class TrafficPolicyCountCheck(QuotaCheck):
Expand All @@ -57,11 +75,11 @@ class TrafficPolicyCountCheck(QuotaCheck):

@property
def maximum(self):
return self.boto_session.client('route53').get_account_limit(Type='MAX_TRAFFIC_POLICIES_BY_OWNER')['Limit']['Value']
return get_route53_account_limits(self.boto_session, "MAX_TRAFFIC_POLICIES_BY_OWNER")["Limit"]["Value"]

@property
def current(self):
return self.boto_session.client('route53').get_account_limit(Type='MAX_TRAFFIC_POLICIES_BY_OWNER')['Count']
return get_route53_account_limits(self.boto_session, "MAX_TRAFFIC_POLICIES_BY_OWNER")["Count"]


class TrafficPolicyInstanceCountCheck(QuotaCheck):
Expand All @@ -72,58 +90,58 @@ class TrafficPolicyInstanceCountCheck(QuotaCheck):

@property
def maximum(self):
return self.boto_session.client('route53').get_account_limit(Type='MAX_TRAFFIC_POLICY_INSTANCES_BY_OWNER')['Limit']['Value']
return get_route53_account_limits(self.boto_session, "MAX_TRAFFIC_POLICY_INSTANCES_BY_OWNER")["Limit"]["Value"]

@property
def current(self):
return self.boto_session.client('route53').get_account_limit(Type='MAX_TRAFFIC_POLICY_INSTANCES_BY_OWNER')['Count']
return get_route53_account_limits(self.boto_session, "MAX_TRAFFIC_POLICY_INSTANCES_BY_OWNER")["Count"]


class RecordsPerHostedZoneCheck(InstanceQuotaCheck):
key = "route53_records_per_hosted_zone"
description = "Records per Route53 Hosted Zone"
instance_id = 'Hosted Zone ID'
instance_id = "Hosted Zone ID"
service_code = "route53"

@staticmethod
def get_all_identifiers(session: boto3.Session) -> typing.List[str]:
return [zone['Id'] for zone in session.client('route53').list_hosted_zones()['HostedZones']]
return [zone["Id"] for zone in list_route53_hosted_zones(session)]

@property
def maximum(self):
try:
return self.boto_session.client('route53').get_hosted_zone_limit(Type='MAX_RRSETS_BY_ZONE', HostedZoneId=self.instance_id)['Limit']['Value']
except self.boto_session.client('route53').exceptions.NoSuchHostedZone as e:
return get_route53_hosted_zone_limits(self.boto_session, "MAX_RRSETS_BY_ZONE", self.instance_id)["Limit"]["Value"]
except self.boto_session.client("route53").exceptions.NoSuchHostedZone as e:
raise InstanceWithIdentifierNotFound(self) from e

@property
def current(self):
try:
return self.boto_session.client('route53').get_hosted_zone_limit(Type='MAX_RRSETS_BY_ZONE', HostedZoneId=self.instance_id)['Count']
except self.boto_session.client('route53').exceptions.NoSuchHostedZone as e:
return get_route53_hosted_zone_limits(self.boto_session, "MAX_RRSETS_BY_ZONE", self.instance_id)["Count"]
except self.boto_session.client("route53").exceptions.NoSuchHostedZone as e:
raise InstanceWithIdentifierNotFound(self) from e


class AssociatedVpcHostedZoneCheck(InstanceQuotaCheck):
key = "route53_vpcs_per_hosted_zone"
description = "Associated VPCs per Route53 Hosted Zone"
instance_id = 'Hosted Zone ID'
instance_id = "Hosted Zone ID"
service_code = "route53"

@staticmethod
def get_all_identifiers(session: boto3.Session) -> typing.List[str]:
return [zone['Id'] for zone in session.client('route53').list_hosted_zones()['HostedZones'] if zone['Config']['PrivateZone']]
return [zone["Id"] for zone in list_route53_hosted_zones(session) if zone["Config"]["PrivateZone"]]

@property
def maximum(self):
try:
return self.boto_session.client('route53').get_hosted_zone_limit(Type='MAX_VPCS_ASSOCIATED_BY_ZONE', HostedZoneId=self.instance_id)['Limit']['Value']
except self.boto_session.client('route53').exceptions.NoSuchHostedZone as e:
return get_route53_hosted_zone_limits(self.boto_session, "MAX_VPCS_ASSOCIATED_BY_ZONE", self.instance_id)["Limit"]["Value"]
except self.boto_session.client("route53").exceptions.NoSuchHostedZone as e:
raise InstanceWithIdentifierNotFound(self) from e

@property
def current(self):
try:
return self.boto_session.client('route53').get_hosted_zone_limit(Type='MAX_VPCS_ASSOCIATED_BY_ZONE', HostedZoneId=self.instance_id)['Count']
except self.boto_session.client('route53').exceptions.NoSuchHostedZone as e:
return get_route53_hosted_zone_limits(self.boto_session, "MAX_VPCS_ASSOCIATED_BY_ZONE", self.instance_id)["Count"]
except self.boto_session.client("route53").exceptions.NoSuchHostedZone as e:
raise InstanceWithIdentifierNotFound(self) from e
Loading