Add Storybook tests #137
Open
Add Storybook tests #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amplify deployment status
|
ptgott
force-pushed
the
paul.gottschling/17-storybook
branch
from
44cc6b3 to
e8b2a97
Compare
ptgott
force-pushed
the
paul.gottschling/17-storybook
branch
from
e8b2a97 to
a09ee70
Compare
ptgott
force-pushed
the
paul.gottschling/17-storybook
branch
from
a09ee70 to
65a3581
Compare
ptgott
force-pushed
the
paul.gottschling/17-storybook
branch
from
231d71f to
87cf186
Compare
ptgott
force-pushed
the
paul.gottschling/17-storybook
branch
from
631b857 to
d935d2b
Compare
ptgott
force-pushed
the
paul.gottschling/17-storybook
branch
from
d935d2b to
56d24cb
Compare
Prevent regressions in our custom components by adding Storybook testing. Copy Storybook tests from the archived `gravitational/docs` repo. Add a rough-and-ready Storybook configuration to enable tests to pass. One significant complication is that Docusaurus generates a Webpack configuration when building a docs site. There are Storybook frameworks and add-ons for Docusaurus that take advantage of Docusaurus's asset-loading logic, but none are currently being maintained. The quickest thing we can do is add a separate Webpack configuration that renders components in Storybook similarly (but not identically) to the Docusaurus site. A separate change can refine this approach by, for example: - Vendoring a Storybook Docusaurus framework - Migrating Storybook tests to `react-testing-library` Also add a step to the `Run tests` GitHub Actions job to run the Storybook tests.
ptgott
force-pushed
the
paul.gottschling/17-storybook
branch
from
56d24cb to
aef9425
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent regressions in our custom components by adding Storybook testing. Copy Storybook tests from the archived
gravitational/docsrepo. Add a rough-and-ready Storybook configuration to enable tests to pass.One significant complication is that Docusaurus generates a Webpack configuration when building a docs site. There are Storybook frameworks and add-ons for Docusaurus that take advantage of Docusaurus's asset-loading logic, but none are currently being maintained. The quickest thing we can do is add a separate Webpack configuration that renders components in Storybook similarly (but not identically) to the Docusaurus site.
A separate change can refine this approach by, for example:
react-testing-library