This repository has been archived by the owner on Jan 8, 2025. It is now read-only.
Navigation menu keyboard events #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hello, would you mind adding a brief description of the expected behavior to help me test this? Thanks! |
Hey, yes absolutely, sorry about that! I added the expected behavior in the description |
ptgott
approved these changes
Oct 3, 2024
avatus
approved these changes
Oct 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://docs-git-pietikinnunen-nav-accessibility-goteleport.vercel.app/docs/
Enables very basic keyboard navigation for the header nav menu and aria-expanded values to improve the accessibility of the site.
taborshift+tabto go through the header navigation items.spaceorenter/returnkey when a main navigation menu item or a submenu is in focus should open it.escapewhen any navigation item is in focus should close the navigationAssociated PRs in the other repos:
https://github.com/gravitational/next/pull/2542
https://github.com/gravitational/blog/pull/564