Tooling for Mac Distribution #324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
reviewed
Feb 7, 2025
|
|
||
| By default, notarization is disabled and will output dryrun logs. To enable it you must either set the following options: | ||
| ```shell | ||
| mac-distribution --apple-username="" --apple-password="" --signing-identity="" --bundle-id="" ... |
There was a problem hiding this comment.
Should we support flags at all? Doesn't this just make it more likely that secrets get recorded in shell history files?
r0mant
reviewed
Feb 8, 2025
|
|
||
| App Bundle (.app) | ||
| ```shell | ||
| mac-distribution package-app tsh tsh.app/ |
There was a problem hiding this comment.
Instead of having a separate tool for every artifact, what do you think about having a single build tool with subcommands that we can extend as we convert more stuff? E.g. something like:
$ tbuild build-mac ... --notarize
camscale
reviewed
Feb 10, 2025
rosstimothy
reviewed
Mar 3, 2025
tools/mac-distribution/go.mod
Outdated
|
|
||
| require ( | ||
| github.com/alecthomas/kong v1.8.1 | ||
| github.com/gravitational/trace v1.5.0 |
There was a problem hiding this comment.
Do we need to use trace here? Should we prefer the native error wrapping provided by Go instead?
There was a problem hiding this comment.
Yeah I've seen some talk about this before. It seems we would rather want to reduce dependency on this library. I'll remove the dependency and prefer idiomatic Go error handling.
* Copying files preserves perms by default and removes dest on errors * Appbundle sets perms for binary correctly * Copy should properly propagate Close errors * Notarize binaries no longer creates a staging dir for zipping * Moving around packaging files * Unexporting submissionResponseData * Using byte slice for stdout * Fixing zipper archiveName * Cleaning up notarytool * Cleaning up some packaging names * Cleaning up main
doggydogworld
force-pushed
the
gus/mac-tooling
branch
from
a800065 to
58721cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.