OCI join method - Add client auth ceremony #51445
Merged
+690
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atburke
added
the
no-changelog
rosstimothy
reviewed
Jan 28, 2025
atburke
force-pushed
the
atburke/oci-join-2
branch
from
e353656 to
acaf9c2
Compare
nklaassen
approved these changes
Jan 29, 2025
atburke
force-pushed
the
atburke/oci-join-1
branch
4 times, most recently
from
9e12491 to
3323789
Compare
atburke
force-pushed
the
atburke/oci-join-2
branch
from
acaf9c2 to
6ad2308
Compare
atburke
force-pushed
the
atburke/oci-join-2
branch
from
6ad2308 to
21128b0
Compare
strideynet
approved these changes
Jan 30, 2025
public-teleport-github-review-bot
bot
removed the request for review
from rudream
bl-nero
reviewed
Jan 30, 2025
rosstimothy
reviewed
Jan 31, 2025
rosstimothy
approved these changes
Feb 3, 2025
lib/auth/join/oracle/oracle.go
Outdated
| return string(canonicalRegion), realm | ||
| } | ||
|
|
||
| var ociRealms = []string{ |
There was a problem hiding this comment.
The realm lookup could be constant time instead of linear if this was a set
Suggested change
| var ociRealms = []string{ | |
| var ociRealms = map[string]struct{}{ |
This change adds the client side of the auth ceremony for the Oracle join method.
atburke
force-pushed
the
atburke/oci-join-2
branch
from
d647b43 to
db0511e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the client side of the auth ceremony for the Oracle join method (RFD).
Part of #41705.
Follows #51444.