Deflake TestStaticHostUserHandler #51578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atburke
added
no-changelog
Tener
approved these changes
Jan 29, 2025
hugoShaka
reviewed
Jan 29, 2025
|
@hugoShaka Yeah, basically. Both the retry handler and watcher timeout use the same clock, and |
hugoShaka
approved these changes
Jan 31, 2025
atburke
force-pushed
the
atburke/shu-handler-flake
branch
from
e76da05 to
61e7476
Compare
atburke
added a commit
that referenced
this pull request
Feb 1, 2025
atburke
added a commit
that referenced
this pull request
Feb 1, 2025
This was referenced Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change deflakes TestStaticHostUserHandler, which was occasionally deadlocking due to clock shenanigans.
Resolves #51173.