Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Okta: Backend/type changes for Okta Integration enrolment improvements #51731

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kiosion
Copy link
Contributor

@kiosion kiosion commented Jan 31, 2025

Add types and update integration status page + enrol paths for Okta Integration enrolment changes. Required for #5994.

@kiosion kiosion added the no-changelog Indicates that a PR does not require a changelog entry label Jan 31, 2025
@kiosion kiosion force-pushed the maxim/new-okta-setup branch 5 times, most recently from c34e938 to f2b7a4e Compare February 4, 2025 15:49
@kiosion kiosion marked this pull request as ready for review February 4, 2025 16:07
lib/web/oidcidp.go Outdated Show resolved Hide resolved
web/packages/teleport/src/services/integrations/types.ts Outdated Show resolved Hide resolved
lib/web/oidcidp.go Outdated Show resolved Hide resolved
getIntegrationStatusRoute(
type: PluginKind | IntegrationKind,
name: string,
page?: string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: from the PR description, I think we are referring to status page here correct?

Suggested change
page?: string
statusPage?: string

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for the Edit routes for the User Sync / App/Group Sync within the Okta status page... would something like subPage be more apt?

web/packages/teleport/src/services/integrations/types.ts Outdated Show resolved Hide resolved
@kiosion kiosion force-pushed the maxim/new-okta-setup branch from f2b7a4e to 91cee35 Compare February 7, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants