Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch relevant regions for agents endpoint #51814

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

michellescripts
Copy link
Contributor

@michellescripts michellescripts commented Feb 4, 2025

This PR updates the region logic for the aws oidc database services; it checks for relevant regions, and then applies a filter to that subset if applicable. This prevents us from trying to get services from regions that are not yet set up.

Supports #49855

Before:
Screenshot 2025-02-03 at 11 56 27 AM

@michellescripts michellescripts force-pushed the michelle/agent-regions branch 4 times, most recently from 8e32fde to a24eeef Compare February 5, 2025 00:01
@michellescripts michellescripts marked this pull request as ready for review February 5, 2025 00:05
@github-actions github-actions bot requested review from creack and kimlisa February 5, 2025 00:06
@michellescripts michellescripts added the no-changelog Indicates that a PR does not require a changelog entry label Feb 5, 2025
Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a couple nitpicks

lib/web/integrations_awsoidc.go Outdated Show resolved Hide resolved
lib/web/integrations_awsoidc.go Outdated Show resolved Hide resolved
lib/web/integrations_awsoidc.go Show resolved Hide resolved
Copy link
Contributor

@marcoandredinis marcoandredinis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add deduplication of regions before calling listDeployedDatabaseServices?
I can do it in a follow up PR, if you prefer

lib/web/integrations_awsoidc.go Show resolved Hide resolved
@michellescripts michellescripts added this pull request to the merge queue Feb 7, 2025
Merged via the queue into master with commit cb07b42 Feb 7, 2025
41 checks passed
@michellescripts michellescripts deleted the michelle/agent-regions branch February 7, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants