-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch relevant regions for agents endpoint #51814
Conversation
8e32fde
to
a24eeef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with a couple nitpicks
2270913
to
c9c01a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add deduplication of regions before calling listDeployedDatabaseServices
?
I can do it in a follow up PR, if you prefer
c9c01a1
to
d632e40
Compare
d632e40
to
4861025
Compare
This PR updates the region logic for the aws oidc database services; it checks for relevant regions, and then applies a filter to that subset if applicable. This prevents us from trying to get services from regions that are not yet set up.
Supports #49855
Before:
![Screenshot 2025-02-03 at 11 56 27 AM](https://private-user-images.githubusercontent.com/11967646/409775959-f63ce8f3-a7d1-4d61-b376-8f8e882fa639.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMzE1MDAsIm5iZiI6MTczOTEzMTIwMCwicGF0aCI6Ii8xMTk2NzY0Ni80MDk3NzU5NTktZjYzY2U4ZjMtYTdkMS00ZDYxLWIzNzYtOGY4ZTg4MmZhNjM5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDIwMDAwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNjMDMzYTZiNGJjY2ZlN2M3YjI3MzMwM2YzMjE4NTExY2E2YjE5MTc0YjNlYjBmZTQ4MmVlZmM4ZDAzYjIxM2YmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.XscOh89Sol4V9LYQ-xCrLNiyivubm07Dvib_prapZ3c)