access_monitoring_rule: Support plugin.spec.name
condition variable
#51816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports #51682
This PR adds supports for using
plugin.spec.name
variable within the condition expression.The
plugin.spec.name
will replace thespec.notification.name
. This is more of a UX change. We can deprecate thespec.notification.name
but continue to support it. With built-in/native auto approvals, we'd like to support auto approvals without notifications. It would be a bit confusing to continue usingspec.notification.name
in this scenario.There is one notable change in behavior with these changes. The AMR can now be configured to match all available plugins, because the
spec.notification.name
can be empty. If this is an undesirable change, we can add an extra validation step to ensure that aplugin.spec.name
variable is used within the condition expression.Changelog: Support
plugin.spec.name
AMR condition variable.