Confirm regions filter is not empty #51978
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsequent use of regionsFilter was checking that the length is greater than 0, but the UI will always send an empty key if no region is selected (
®ions=
). This was resulting in a region filter of empty string.We talked about having the UI send all regions if none were selected, but its a bit of an anti-pattern and
diverges from what we're doing with other endpoints
Supports #49088