Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm regions filter is not empty #51978

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Confirm regions filter is not empty #51978

merged 1 commit into from
Feb 10, 2025

Conversation

michellescripts
Copy link
Contributor

@michellescripts michellescripts commented Feb 7, 2025

Subsequent use of regionsFilter was checking that the length is greater than 0, but the UI will always send an empty key if no region is selected (&regions=). This was resulting in a region filter of empty string.

We talked about having the UI send all regions if none were selected, but its a bit of an anti-pattern and
diverges from what we're doing with other endpoints

Supports #49088

@michellescripts michellescripts changed the title Confirm regions filter isnt empty Confirm regions filter is not empty Feb 7, 2025
@michellescripts michellescripts marked this pull request as ready for review February 7, 2025 21:05
@github-actions github-actions bot requested review from ravicious and rudream February 7, 2025 21:06
@michellescripts michellescripts added the no-changelog Indicates that a PR does not require a changelog entry label Feb 7, 2025
@michellescripts michellescripts added this pull request to the merge queue Feb 10, 2025
Merged via the queue into master with commit 309e54b Feb 10, 2025
41 of 42 checks passed
@michellescripts michellescripts deleted the michelle/rules branch February 10, 2025 16:33
@public-teleport-github-review-bot

@michellescripts See the table below for backport results.

Branch Result
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants