Add iterators to unified resource cache #52103
Open
+900
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
added
the
no-changelog
rosstimothy
force-pushed
the
tross/urc_iteration
branch
4 times, most recently
from
124228e to
ff4cc96
Compare
avatus
reviewed
Feb 13, 2025
avatus
reviewed
Feb 14, 2025
rosstimothy
force-pushed
the
tross/urc_iteration
branch
7 times, most recently
from
e2ce7c1 to
b43230f
Compare
This updates the UnifiedResourceCache with IterateResources as an alternative to IterateUnifiedResources. The new function returns an iterator instead of collecting and returning a page of results. While this API may not entirely replace the current one, it offers a better way for users that just want to iterate resources without collecting them. Additionally, a few helper methods were included for callers that might wish to only iterate one specific resource type. Internally the UnifiedResourceCache was refactored to use the same logic for all exposed iteration methods.
rosstimothy
force-pushed
the
tross/urc_iteration
branch
from
b43230f to
3621abd
Compare
avatus
approved these changes
Feb 18, 2025
| ) | ||
| // IterateWindowsDesktops iterates over all cached windows desktops starting from the provided key. | ||
| func (c *UnifiedResourceCache) IterateWindowsDesktops(ctx context.Context, start string, order IterationOrder) iter.Seq2[types.WindowsDesktop, error] { | ||
| return iterateUnifiedResourceCache(ctx, c, start, order, types.KindWindowsDesktop, func(desktop types.WindowsDesktop) types.WindowsDesktop { return desktop.Copy() }) |
There was a problem hiding this comment.
why cant this copy func just be types.WindowsDesktop.Copy like the other types?
There was a problem hiding this comment.
The compiler won't allow that because of the return type
// Copy returns a copy of this dynamic Windows desktop
Copy() *DynamicWindowsDesktopV1
There was a problem hiding this comment.
ah, guess i could have just tried myself :)
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the UnifiedResourceCache with IterateResources as an alternative to IterateUnifiedResources. The new function returns an iterator instead of collecting and returning a page of results. While this API may not entirely replace the current one, it offers a better way for users that just want to iterate resources without collecting them. Additionally, a few helper methods were included for callers that might wish to only iterate one specific resource type. Internally the UnifiedResourceCache was refactored to use the same logic for all exposed iteration methods.