Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI: support SAML app launch URLs #52877

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

flyinghermit
Copy link
Contributor

@flyinghermit flyinghermit commented Mar 7, 2025

This PR implements <MenuLoginWithActionMenu> button and handles launch URLs for SAML app.

Notable changes:

  • <MenuLogin> is updated to handle launchExternalUrl to render <a> tag links instead of with the NavLink. disableSearchAndFilter props specifies to render menu item label instead of the default search/filter input.
  • <MenuLoginWithActionMenu> extends <MenuLogin> button and renders similar to <ButtonWithMenu> component. TO support SAML app launch URLs, we need button to show selectable URLs.
  • If there are zero launch URL, default <ButtonWithMenu> is displayed with the value of SAML ACS URL. If there is only one launch URL, <ButtonWithMenu> border is displayed with the href value configured with the launch URL value. If there are 1+ launch URL items, <MenuLoginWithActionMenu> is displayed.
  • For instances where SAML action button will not be displayed, regular <ButtonBorder> and <MenuLogin> button is displayed with the login items similarly configured as explained above.

The launch URLs can only be configured with tctl. Use this sample spec to configure SAML service provider for testing:

kind: saml_idp_service_provider
metadata:
  name: my_saml_app
spec:
  acs_url: https:/example.com
  entity_id: https:/example.com
  launch_urls:
    - https:/example.com/2
    - https:/example.com/1
version: v1

Note: SAML apps can be launched from Connect but this PR does not cover it. I will follow up separately.

Implements UI for launch URL #46416

@flyinghermit
Copy link
Contributor Author

both selectable and direct link login button displayed below:
Screenshot 2025-03-07 at 7 33 49 PM

@flyinghermit flyinghermit marked this pull request as ready for review March 8, 2025 01:54
@flyinghermit flyinghermit added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v17 labels Mar 8, 2025
@github-actions github-actions bot requested review from gzdunek and ryanclark March 8, 2025 01:55
@flyinghermit flyinghermit requested review from ravicious and avatus and removed request for ryanclark and gzdunek March 8, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/lg ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant