Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delete all entities linked to a domain when the domain is deleted #1620

Draft
wants to merge 1 commit into
base: 3.10.x
Choose a base branch
from
Draft

fix: delete all entities linked to a domain when the domain is deleted #1620

wants to merge 1 commit into from

Conversation

leleueri
Copy link
Contributor

@leleueri leleueri requested a review from a team January 21, 2022 16:09
tcompiegne
tcompiegne requested changes Jan 21, 2022
View reviewed changes
Copy link
Member

@tcompiegne tcompiegne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can implement the deleteByReference method for all the repositories involved with the domain deletion.

@leleueri leleueri force-pushed the issues/#6987-optimize-delete-domain branch from f83a8b0 to 6e0ed72 Compare January 24, 2022 15:37
@leleueri leleueri changed the title fix: delete all user by domain when a domain is rmeoved fix: delete all user by domain when a domain is removed Jan 24, 2022
@leleueri leleueri force-pushed the issues/#6987-optimize-delete-domain branch from 6e0ed72 to fb4f3ae Compare January 24, 2022 15:38
@tcompiegne tcompiegne changed the title fix: delete all user by domain when a domain is removed fix: delete all entities linked to a domain when the domain is deleted Jan 24, 2022
@tcompiegne tcompiegne force-pushed the issues/#6987-optimize-delete-domain branch from fb4f3ae to 3b6e48d Compare January 25, 2022 09:52
@tcompiegne tcompiegne force-pushed the issues/#6987-optimize-delete-domain branch from 3b6e48d to 33b3a7a Compare January 25, 2022 13:44
@tcompiegne tcompiegne marked this pull request as draft January 25, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcompiegne tcompiegne tcompiegne approved these changes

Assignees
No one assigned
Labels
status: on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leleueri @tcompiegne