feat(helm): allow configuring security section of management api conf… #4941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ig via Helm values AM-4057
|
leleueri
requested changes
Oct 4, 2024
Comment on lines
+399
to
+408
| security: | ||
| defaultAdmin: {{ .Values.api.security.defaultAdmin | default true }} | ||
| accountAccessTokens: | ||
| encoder: | ||
| settings: | ||
| rounds: {{ .Values.api.security.accountTokenBcryptRounds | default 10 }} | ||
| {{- if .Values.api.security.providers }} | ||
| providers: | ||
| {{- toYaml .Values.api.security.providers | nindent 8 }} | ||
| {{- end}} |
There was a problem hiding this comment.
suggestion: I would do a test on the security section as you did for .Values.api.security.providers line 405. In that way we are expecting the same structure as the one in the gravitee.yaml. And in future if new entries in the security section are added, they will be taken into account automatically. wdyt ?
Comment on lines
+439
to
+462
| security: | ||
| defaultAdmin: true | ||
| accountTokenBcryptRounds: 10 | ||
| providers: | ||
| - type: memory | ||
| enabled: false | ||
| ## Name of IdentityProvider | ||
| ## If missing the type will be used to create a generic name (ex: Memory users) | ||
| #name: | ||
| ## password encoding/hashing algorithm. One of: | ||
| ## - BCrypt : passwords are hashed with bcrypt (supports only $2a$ algorithm) | ||
| ## - none : passwords are not hashed/encrypted | ||
| #default value is BCrypt | ||
| password-encoding-algo: BCrypt | ||
| users: | ||
| - user: | ||
| username: admin | ||
| #email: | ||
| firstname: Administrator | ||
| lastname: Administrator | ||
| ## Passwords are encoded using BCrypt | ||
| ## Password value: adminadmin | ||
| password: $2a$10$NG5WLbspq8V1yJDzUKfUK.oum94qL/Ne3B5fQCgekw/Y4aOEaoFZq | ||
| role: ORGANIZATION_OWNER |
There was a problem hiding this comment.
if you accept the comment made for the api-configmap.yalm this section will have to be updated for the accountToken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ig via Helm values
AM-4057