On branch fix/definition-list-a11y: review fixes

gravity-ui · Jul 10, 2024 · 07d9529 · 07d9529
1 parent 626df78
commit 07d9529
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -123,4 +123,4 @@
       "prettier --write"
     ]
   }
-}
+}
diff --git a/src/components/DefinitionList/components/Term.tsx b/src/components/DefinitionList/components/Term.tsx
@@ -28,15 +28,17 @@ function NoteElement({note}: NoteElementsProps) {
     }
 
     if (typeof note === 'object') {
+        const {buttonProps, ...rest} = note;
+
         return (
             <HelpPopover
                 className={popoverClassName}
                 placement={['bottom', 'top']}
-                {...note}
                 buttonProps={{
                     'aria-label': i18n('label_note'),
-                    ...note.buttonProps,
+                    ...buttonProps,
                 }}
+                {...rest}
             />
         );
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -123,4 +123,4 @@ @@
           "prettier --write"
         ]
       }
-    }
+    }