Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: terminate on signal without exit process #27

Merged
merged 3 commits into from
Mar 7, 2025
Merged

feat!: terminate on signal without exit process #27

merged 3 commits into from
Mar 7, 2025

Conversation

eyoue
Copy link
Contributor

@eyoue eyoue commented Mar 6, 2025 •
edited
Loading

Motivation/Problem:

  • on terminate connection OR send signal SIGUSR1, SIGUSR2 process exited
  • can't create the signal processing logic in the application

Changes:

  • remove terminate connections on SIGUSR1, SIGUSR2
  • remove process.exit(...) in terminate connections

@eyoue
fix: terminate on signal
4cd8ef8 
- remove terminate connections on `SIGUSR1`, `SIGUSR2`
- remove `process.exit(...)` in terminate connections
- safe `process.exit(0)` in default `beforeTerminate`
@eyoue eyoue changed the title fix: terminate on signal fix(core/terminate): terminate on signal without exit process Mar 6, 2025
@jhoncool
Copy link
Collaborator

jhoncool commented Mar 7, 2025

@eyoue let's rename PR to feat!: ... and can you add the terminate function to initDB return

@eyoue eyoue changed the title fix(core/terminate): terminate on signal without exit process feat(core/terminate): terminate on signal without exit process Mar 7, 2025
@jhoncool jhoncool changed the title feat(core/terminate): terminate on signal without exit process feat!: terminate on signal without exit process Mar 7, 2025
@jhoncool jhoncool merged commit 90c0b50 into main Mar 7, 2025
4 checks passed
@jhoncool jhoncool deleted the fix_terminate_signals branch March 7, 2025 10:35
@gravity-ui-bot gravity-ui-bot mentioned this pull request Mar 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoncool jhoncool jhoncool approved these changes

@imsitnikov imsitnikov Awaiting requested review from imsitnikov imsitnikov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyoue @jhoncool