fix: remove unused react-dom from peerDependencies
#2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Visual Tests Report is ready. |
ogonkov
changed the title
react-dom from peerDependenciesreact-dom from peer dependencies
ogonkov
changed the title
react-dom from peer dependenciesreact-dom from peerDependencies
ogonkov
force-pushed
the
chore/rm_react_dom_peer
branch
from
543e6f5 to
5adab77
Compare
|
@ogonkov I think keeping it has no harm. In case if we need it again later we won't be locked by major change adding a peer |
|
@amje in projects without react-dom this cause error on install, because react-dom@19 resolved by npm I dont see point to keep in peers dependency that we didnt use in code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-domwas used in Toaster