Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support local working image CDN support #148

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aghreed
Copy link
Contributor

@aghreed aghreed commented Mar 14, 2023

Purpose

Fixes an issue I introduced with #123 where locally you'll get issues running your site as the syntax will be for gatsbyImageData rather than the gatsbyImage ImageCDN query.

This also re-introduces the mode option initially purposed to control ImageCDN support and makes it so that either mode or the GATSBY_CLOUD_IMAGE_CDN env var that is provided by Gatsby Cloud during Gatsby Cloud builds will trigger the plugin to create ImageCDN compatible nodes.

Testing

Locally gatsby develop is working with a demo site I'm using, however gatsby build and gatsby serve is having issues finding the images. Putting this PR back into draft until I can get to the bottom on that.

However, on Gatsby Cloud, this is working just fine. Build URL: https://build-b55a8a8d-761a-458d-a31b-d99c233f1499.gatsbyjs.io/

@aghreed aghreed marked this pull request as draft March 15, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant