set up dedicated logger to retain CLI stdout #246
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons/cloud into m/set_up_progress_logger
rreinoldsc
commented
May 3, 2024
| @@ -90,6 +90,10 @@ def main() -> None: | |||
| ) | |||
| ) | |||
|
|
|||
| agent_logger = logging.getLogger( | |||
There was a problem hiding this comment.
Some notes:
- This is set here and passed in bc logger must be aware of logging_cfg
- We want a logger name that is not the agent's name to avoid submodules inheriting the INFO level
…_up_progress_logger
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
===========================================
- Coverage 84.71% 66.18% -18.54%
===========================================
Files 25 25
Lines 962 961 -1
===========================================
- Hits 815 636 -179
- Misses 147 325 +178
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Kilo59
reviewed
Jun 5, 2024
@Kilo59 I'm going to rework this, and then I'll ping you for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure a logger to retain same CLI UX for agent with structured logging