Fix duplicate slashes in url #505
Open
+84
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #505 +/- ##
==========================================
+ Coverage 87.96% 88.03% +0.06%
==========================================
Files 24 24
Lines 1030 1036 +6
==========================================
+ Hits 906 912 +6
Misses 124 124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…shes-in-url' into b/_/zelda-1060/fix-duplicate-slashes-in-url # Conflicts: # pyproject.toml
anthonyburdi
changed the title
Shinnnyshinshin
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
looks awesome. super clear, well tested. Thanks so much for doing this @anthonyburdi
rreinoldsc
reviewed
Oct 23, 2024
| def test_construct_url_from_base_plus_path(base: str, path: str, expected_url: str): | ||
| """Test that urljoin constructs all combinations of urls correctly.""" | ||
| constructed_url = urljoin(base, path) | ||
| assert constructed_url == expected_url |
There was a problem hiding this comment.
no need to test urljoin itself
There was a problem hiding this comment.
Yeah you're right - I wrote this test when I had a custom fn. Will clean it up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are getting errors due to duplicate slashes in urls e.g. this error.
This PR is intended to make the agent more resilient when constructing urls. In the future we can also consider using a url object instead of strings, and then construct the string when needed.